Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated reference to writernames #3686

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

tomasMizera
Copy link
Collaborator

@tomasMizera tomasMizera commented Dec 2, 2024

Luckily, it was read as an optional key so there is no need to keep the server compatible :)

@tomasMizera tomasMizera requested a review from wonder-sk December 2, 2024 09:30
Copy link

github-actions bot commented Dec 2, 2024

Pull Request Test Coverage Report for Build 12116425662

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 36 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.1%) to 60.442%

Files with Coverage Reduction New Missed Lines %
input/app/main.cpp 2 32.65%
input/core/merginuserinfo.cpp 3 73.76%
input/app/notificationmodel.cpp 3 49.44%
input/core/merginprojectmetadata.cpp 4 88.51%
input/core/merginuserauth.cpp 9 75.95%
input/core/merginapi.cpp 15 78.73%
Totals Coverage Status
Change from base Build 12009384500: -0.1%
Covered Lines: 7881
Relevant Lines: 13039

💛 - Coveralls

@tomasMizera tomasMizera merged commit 185dfb9 into master Dec 3, 2024
9 checks passed
@tomasMizera tomasMizera deleted the remove-deprecated-keys branch December 3, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants