Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving UX by hiding editing buttons for readers of a project #3682

Merged
merged 23 commits into from
Jan 23, 2025
Merged

Improving UX by hiding editing buttons for readers of a project #3682

merged 23 commits into from
Jan 23, 2025

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented Nov 18, 2024 •
edited
Loading

While in Reader role, editing buttons are no longer visible to user. These buttons include:

Main Add button and the one within the features list.
Add feature button and its variations.
Edit feature button and its variations.
Edit geometry button.

Reader Other Roles

Resolves #3174

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12918255508

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 228 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.3%) to 60.838%
Files with Coverage Reduction New Missed Lines %
input/core/merginprojectmetadata.cpp 3 88.64%
input/core/coreutils.cpp 21 85.57%
input/app/activeproject.cpp 47 68.54%
input/app/main.cpp 74 34.46%
input/core/merginapi.cpp 83 79.68%
Totals Coverage Status
Change from base Build 12873267977: 0.3%
Covered Lines: 8033
Relevant Lines: 13204
💛 - Coveralls

@VitorVieiraZ VitorVieiraZ changed the title WIP - Improving UX by hiding editing buttons for readers and guests of a project Improving UX by hiding editing buttons for readers and guests of a project Dec 10, 2024
@VitorVieiraZ VitorVieiraZ changed the title Improving UX by hiding editing buttons for readers and guests of a project Improving UX by hiding editing buttons for readers of a project Dec 10, 2024
tomasMizera
tomasMizera requested changes Jan 6, 2025
View reviewed changes
core/merginprojectmetadata.h Outdated Show resolved Hide resolved
app/qml/project/MMProjectController.qml Outdated Show resolved Hide resolved
tomasMizera
tomasMizera requested changes Jan 15, 2025
View reviewed changes
app/activeproject.h Outdated Show resolved Hide resolved
core/merginapi.cpp Outdated Show resolved Hide resolved
core/merginapi.cpp Outdated Show resolved Hide resolved
core/merginapi.cpp Outdated Show resolved Hide resolved
app/activeproject.cpp Outdated Show resolved Hide resolved
tomasMizera
tomasMizera requested changes Jan 20, 2025
View reviewed changes
core/coreutils.h Show resolved Hide resolved
tomasMizera
tomasMizera reviewed Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small adjustments and we are ready to go 🚀

app/activeproject.h Outdated Show resolved Hide resolved
app/activeproject.h Outdated Show resolved Hide resolved
app/test/testcoreutils.cpp Show resolved Hide resolved
core/merginapi.h Outdated Show resolved Hide resolved
app/test/testmerginapi.cpp Outdated Show resolved Hide resolved
tomasMizera
tomasMizera approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tomasMizera tomasMizera merged commit 6115084 into master Jan 23, 2025
8 of 9 checks passed
@tomasMizera
Copy link
Collaborator

Merging, CI will pass on master 🙃

@tomasMizera tomasMizera deleted the enhancementUiUx/readerCantEdit branch January 23, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasMizera tomasMizera tomasMizera approved these changes

@ValentinBuira ValentinBuira Awaiting requested review from ValentinBuira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Users unable to sync project after a reader user makes some local changes
3 participants
@VitorVieiraZ @tomasMizera @inputapp-bot