Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix download of files >= 2GB #2894

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Fix download of files >= 2GB #2894

merged 1 commit into from
Nov 9, 2023

Conversation

wonder-sk
Copy link
Contributor

Fixes #2808

  • JSON parsing: use toInteger() instead of toInt() for big numbers (returns qint64 instead of int)
  • store sizes and file offsets as qint64 instead of int

@wonder-sk
Fix download of files >= 2GB
179a064 
Fixes #2808

- JSON parsing: use toInteger() instead of toInt() for big numbers (returns qint64 instead of int)
- store sizes and file offsets as qint64 instead of int
@PeterPetrik PeterPetrik added the ready-for-testing Ready to be tested by testers crew - passed review by devs label Nov 1, 2023
@jozef-budac
Copy link

@PeterPetrik this looks OK, I was able to download whole 3GB of the project. It took 40 min or so :)

@PeterPetrik PeterPetrik merged commit cb195fa into master Nov 9, 2023
6 of 8 checks passed
@PeterPetrik PeterPetrik deleted the fix-large-files branch November 9, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterPetrik PeterPetrik PeterPetrik approved these changes

Assignees
No one assigned
Labels
ready-for-testing Ready to be tested by testers crew - passed review by devs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data corruption when there is a file with large size
3 participants
@wonder-sk @jozef-budac @PeterPetrik