Init and refresh tags file #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reload config and restart extension when config changes. * Add `initTagsCommand` and `refreshTagsCommand` to `TagsConfig`. * Add _Restart Alloglot_ command.
aljce
approved these changes
Mar 4, 2024
| globalContext && disposeAll(globalContext) | ||
| } | ||
|
|
||
| function disposeAll(context: vscode.ExtensionContext) { |
There was a problem hiding this comment.
Anyway we can make this kill the spawned processes here? So we don't need to do that trap stuff?
There was a problem hiding this comment.
VS Code does kill the spawned language server. Our problem is slightly different, though. Our "language server" is a script that forks ghciwatch and starts the real language server, static-ls. VS Code will kill static-ls without issue. The trap causes ghciwatch to die whenever static-ls dies. Without trap, VS Code will kill static-ls, but ghciwatch will be left a zombie.
|
A PR to release these changes has been created, bumping the version from 2.3.0 to 2.3.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reload config and restart extension when config changes.
Add
initTagsCommandandrefreshTagsCommandtoTagsConfig.Add Restart Alloglot command.