Use default workspace config if available and no settings config #30
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsumabat
force-pushed
the
joseph/default-workspace-config
branch
from
c92c7f9 to
04e2e69
Compare
josephsumabat
force-pushed
the
joseph/default-workspace-config
branch
from
04e2e69 to
8e1009b
Compare
friedbrice
reviewed
Feb 14, 2024
|
|
||
| export function activate(context: vscode.ExtensionContext): void { | ||
| const settingsSection = vscode.workspace.getConfiguration(alloglot.root) | ||
| const alloglotWorkspaceLanguages = getWorkspaceConfig('.vscode/alloglot.json'); | ||
| const alloglotVscodeLanguages = settingsSection.get<Array<LanguageConfig>>(alloglot.config.languages, []) | ||
| const alloglotLanguages = alloglotVscodeLanguages.length === 0 ? alloglotWorkspaceLanguages : alloglotVscodeLanguages; |
There was a problem hiding this comment.
ah, so it's either wholesale override, rather than merge. that's a lot easier to implement, and more predictable for end users.
friedbrice
approved these changes
Feb 14, 2024
|
A PR to release these changes has been created, bumping the version from 2.2.0 to 2.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to have a canned workspace config (
.vscode/alloglot.json) that can be overriden by any vscode settings file (settings.jsonfor example). This will reduce the setup on mwb to simply installing the extension