Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move {gsDesign2} to Suggests #304

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Move {gsDesign2} to Suggests #304

merged 1 commit into from
Jan 8, 2025

Conversation

jdblischak
Copy link
Collaborator

Follow-up to #301

Removes the following NOTE from R CMD check:

❯ checking dependencies in R code ... NOTE
  Namespace in Imports field not imported from: 'gsDesign2'
    All declared Imports should be used.

@jdblischak jdblischak self-assigned this Dec 20, 2024
@jdblischak
Copy link
Collaborator Author

More xref's: #296 (comment), #297 (review)

LittleBeannie
LittleBeannie approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@LittleBeannie LittleBeannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you, @jdblischak !

@LittleBeannie LittleBeannie merged commit 258a911 into Merck:main Jan 8, 2025
7 checks passed
@jdblischak jdblischak deleted the gsdesign2-suggests branch January 8, 2025 20:17
@jdblischak jdblischak mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleBeannie LittleBeannie LittleBeannie approved these changes

Assignees

@jdblischak jdblischak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdblischak @LittleBeannie