Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove markdown and remotes from Suggests #149

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Remove markdown and remotes from Suggests #149

merged 1 commit into from
Nov 27, 2023

Conversation

nanxstats
Copy link
Collaborator

This PR removes markdown and remotes from Suggests.

remotes was introduced in 04b36d0 for comparing data.table results to a previous dplyr-based version of simtrial in tests. Since the test has been removed in #135, remotes is not needed anymore.

markdown was introduced in 2118701 for unknown reasons. It is not used anywhere.

@jdblischak
Copy link
Collaborator

remotes was introduced in 04b36d0 for comparing data.table results to a previous dplyr-based version of simtrial in tests. Since the test has been removed in #135, remotes is not needed anymore.

Thanks for cleaning that up

markdown was introduced in 2118701 for unknown reasons. It is not used anywhere.

I suspect that was motivated by the change in knitr 1.34 to move markdown from Imports to Suggests. Though maybe not, since the commit was in May 2021, but 1.34 wasn't released until Sep 2021. Regardless, the vignettes were using the engine knitr::rmarkdown even back then, so I doubt that markdown was ever actually needed as a dependency

%\VignetteEngine{knitr::rmarkdown}

@nanxstats
Copy link
Collaborator Author

I suspect that was motivated by the change in knitr 1.34 to move markdown from Imports to Suggests. Though maybe not, since the commit was in May 2021, but 1.34 wasn't released until Sep 2021. Regardless, the vignettes were using the engine knitr::rmarkdown even back then, so I doubt that markdown was ever actually needed as a dependency

Good reasoning - I don't think we ever used R Markdown v1 (via the markdown package) since R Markdown v2 (rmarkdown) was released like 10 years ago... so I'd say it's probably added by accident. 😅

@nanxstats nanxstats merged commit 1b7ffd4 into main Nov 27, 2023
7 checks passed
@nanxstats nanxstats deleted the deps branch November 27, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants