Skip to content
This repository has been archived by the owner on Jan 18, 2018. It is now read-only.

Added dogescript #12

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ThomasHickman
Copy link
Contributor

No description provided.

wow& hideLoadingScreen()

very animations = [/*
*/ "spin",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need that comment anymore tbh

Copy link
Contributor Author

@ThomasHickman ThomasHickman Jan 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is needed because dogescript adds a semicolon to the end of every line starting with "very". I'll change this to statements constructing the array instead though e.g animations dose push "zoom" ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done this in 9044cde

@GrahamCampbell
Copy link
Member

We can't had a dependency on npm, because GitHub won't run that for us.

@ThomasHickman
Copy link
Contributor Author

The npm dependancy is only for showing how to compile the source file, all npm dependant things have been compiled using webpack into the included file - compileDJS.js

This is a much less hacky method of setting the value of animations
than using a javascript initialiser list
@GrahamCampbell
Copy link
Member

Server side/developer side, same problem. Can we avoid having to run tools?

@ThomasHickman
Copy link
Contributor Author

Only the dogescript compiler (and a small helper file) is being compiled using npm on the developer side, the dogescript source file is still being compiled on load by the compiled dogescript compiler - I don't think compiling dogescript on the developer side is going to be much of a problem. If it is, I could manually concatenate all files and dependencies of dogescript into one javascript file, but this is basically what webpack does in it's compilation process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants