feat: Add new config parameter private_key
#260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haleemur
changed the title
private_key
edgarrmondragon
approved these changes
Sep 19, 2024
edgarrmondragon
added a commit
to MeltanoLabs/tap-snowflake
that referenced
this pull request
Sep 20, 2024
# Description * Copy code over from target-snowflake MeltanoLabs/target-snowflake#260, now there is parity between how the target & tap can connect to snowflake (3 ways: password, key pair & browser authentications) * This refactor uses `Enum` for `auth_method` for greater type safety. --------- Co-authored-by: Edgar Ramírez Mondragón <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a config parameter
private_key. This allows a user of target-snowflake to specify theprivate_keydirectly.This is useful in cases where it is difficult to save the private_key to a file but easy to pass in an environment variable (e.g. a container)