feat: Configurable null character sanitization #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
force-pushed
the
sanitize-nulls
branch
from
011036c to
330501b
Compare
|
Good evening 👋 I’ve been trying to sync an MSSQL database and ran into the same issue with null values causing failures and this PR seems to have resolved the problem for me. I am not an active contributor to the project yet but let me know if there’s anything I can do to help get this merged—happy to assist! |
Hi @nickjoanis! The first thing would be addressing the merge conflicts |
edgarrmondragon
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Null characters are currently passed as-is to Postgres despite being unsupported.
If it is encountered, it causes the sink to fail as noted here: #60 with an error like
ValueError: A string literal cannot contain NUL (0x00) characters.This PR introduces a new option called
sanitize_null_text_characterswhich enables sanitization of these characters.