DO NOT MERGE: Test fastjsonschema record validation

MeltanoLabs · Dec 5, 2023 · bebf0cf · bebf0cf
1 parent 16e05f3
commit bebf0cf
Show file tree

Hide file tree

Showing 3 changed files with 112 additions and 18 deletions.
diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -32,7 +32,8 @@ packages = [
 [tool.poetry.dependencies]
 python = "<3.12,>=3.8.1"
 requests = "^2.25.1"
-singer-sdk = ">=0.28,<0.34"
+# singer-sdk = ">=0.28,<0.34"
+singer-sdk = {git = "https://github.com/meltano/sdk.git", rev = "refs/pull/2066/head"}
 psycopg2-binary = "2.9.9"
 sqlalchemy = ">=2.0,<3.0"
 sshtunnel = "0.4.0"

diff --git a/target_postgres/tests/test_target_postgres.py b/target_postgres/tests/test_target_postgres.py
@@ -1,4 +1,5 @@
 """ Postgres target tests """
+
 # flake8: noqa
 import copy
 import io
@@ -9,7 +10,7 @@
 import jsonschema
 import pytest
 import sqlalchemy
-from singer_sdk.exceptions import MissingKeyPropertiesError
+from singer_sdk.exceptions import InvalidRecord, MissingKeyPropertiesError
 from singer_sdk.testing import get_target_test_class, sync_end_to_end
 from sqlalchemy.dialects.postgresql import ARRAY
 from sqlalchemy.types import TEXT, TIMESTAMP
@@ -233,7 +234,7 @@ def test_record_missing_key_property(postgres_target):
 
 
 def test_record_missing_required_property(postgres_target):
-    with pytest.raises(jsonschema.exceptions.ValidationError):
+    with pytest.raises(InvalidRecord):
         file_name = "record_missing_required_property.singer"
         singer_file_to_target(file_name, postgres_target)