Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for git config #169

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Conversation

briancbarrow
Copy link
Collaborator

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Problem/Feature

Address #159

Description of Changes:

  • adds check for git config name and email

Checklist

  • I have self-reviewed the changes being requested
  • I have updated the documentation (if applicable)

@Ujstor
Copy link
Collaborator

Ujstor commented Jan 14, 2024

Works as expected proper log if user and pass in git are not set. Terminal issue caused by the spinner will be resolved in a separate PR.

WindowsTerminal_t43i2llIV8

Copy link
Collaborator

@Ujstor Ujstor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Melkeydev
Copy link
Owner

Works as expected proper log if user and pass in git are not set. Terminal issue caused by the spinner will be resolved in a separate PR.

WindowsTerminal_t43i2llIV8

Is there a ticket/current work being done for the terminal spinner issue?

@Ujstor
Copy link
Collaborator

Ujstor commented Jan 19, 2024

briancbarrow is working on this issue.

@Melkeydev Melkeydev merged commit 9c0efe5 into Melkeydev:main Jan 20, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants