Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced flag #149
Advanced flag #149
Changes from all commits
764211e
17ac719
5133906
16ee61b
3435d0a
96cab16
8b33cae
fa2b04d
9b1d990
ff0591e
48efe09
88c1fcb
205c182
38908ef
46cf194
e6be807
b6072ce
75694cb
ebcf12c
48f15cb
9a883a9
d14676d
61e0786
a454961
38a03df
85c17b4
4e277af
2128157
7e4cb69
1628378
6818735
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
if we get here, cant we make sure to release the terminal for them? Maybe explicitly setting a kill for the terminal? Otherwise it will be hanging and the user needs to close the terminal.
Not blocking, just some food for thought
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would that look like? Would we want to do an
os.Exit
or something like that?Won't the
CheckErr
handle exiting with a non-zero exit code?Sorry if these are simple questions.