Added 'null' Protection to AtBDynamicScenarioFactory
#5787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevented null templates from causing issues in scenario generation by adding a check and skipping them. This ensures better stability and avoids potential crashes during processing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5787 +/- ##
============================================
- Coverage 10.21% 10.19% -0.02%
+ Complexity 6077 6074 -3
============================================
Files 1010 1011 +1
Lines 139311 139505 +194
Branches 20449 20504 +55
============================================
- Hits 14231 14224 -7
- Misses 123711 123909 +198
- Partials 1369 1372 +3 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nulltemplates from causing issues in scenario generation by adding a check and skipping them.Why they're included in the list of player force templates is beyond me, and I wasn't able to track down the root cause. This PR at least stops it from impeding the player's experience.
Fix #5753