Added null Protection to OutstandingScenariosNagLogic for Outstanding Scenario Nags
#5772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, scenarios with null dates were not explicitly handled, which could lead to unexpected behavior. Added a null date check to prevent further processing of such scenarios. This improves stability and guards against potential issues.
Moved the null date check earlier in the loop to avoid potential null pointer exceptions when processing scenarios. This ensures scenarios with null dates are skipped before any operations on their dates are conducted.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5772 +/- ##
============================================
- Coverage 10.21% 10.21% -0.01%
+ Complexity 6076 6074 -2
============================================
Files 1010 1010
Lines 139310 139312 +2
Branches 20448 20449 +1
============================================
- Hits 14231 14228 -3
- Misses 123703 123708 +5
Partials 1376 1376 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5770