Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Education Tag-Along Logic #5764

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

IllianiCBT
Copy link
Collaborator

@IllianiCBT IllianiCBT commented Jan 12, 2025

  • Simplified and clarified tag-along logic for dependents during education journeys.
  • Refactored child processing, accounted for active spouses as dependents, and streamlined status checks.

Fix #5766
Fix #5769

Simplified and clarified tag-along logic for dependents during education journeys. Refactored child processing, accounted for active spouses as dependents, and streamlined status checks. Improved maintainability and readability of the affected methods.
@IllianiCBT IllianiCBT added Bug Personnel Personnel-related Issues labels Jan 12, 2025
@IllianiCBT IllianiCBT self-assigned this Jan 12, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.20%. Comparing base (fd739ba) to head (3709528).
Report is 18 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5764      +/-   ##
============================================
- Coverage     10.21%   10.20%   -0.01%     
+ Complexity     6076     6070       -6     
============================================
  Files          1010     1010              
  Lines        139310   139320      +10     
  Branches      20448    20451       +3     
============================================
- Hits          14231    14224       -7     
- Misses       123703   123721      +18     
+ Partials       1376     1375       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with Co-Pilot and IDEA AI

@HammerGS HammerGS merged commit 206fb97 into MegaMek:master Jan 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Personnel Personnel-related Issues
Projects
None yet
3 participants