Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Birthday Generation for Personnel #5754

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

IllianiCBT
Copy link
Collaborator

  • Updated the birthday generation logic to ensure accurate age calculation based on experience level and affiliation.
  • Constrained random date selection to always occur on or before the current campaign date.

This should address an edge case where under specific circumstances characters could generate with an age 1 year younger than intended.

Updated the birthday generation logic to ensure accurate age calculation based on experience level and affiliation. Constrained random date selection to always occur on or before the current campaign date, improving consistency and realism.
@IllianiCBT IllianiCBT added Bug Personnel Personnel-related Issues labels Jan 11, 2025
@IllianiCBT IllianiCBT self-assigned this Jan 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.20%. Comparing base (fd739ba) to head (6aab372).
Report is 48 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5754      +/-   ##
============================================
- Coverage     10.21%   10.20%   -0.01%     
+ Complexity     6076     6073       -3     
============================================
  Files          1010     1010              
  Lines        139310   139312       +2     
  Branches      20448    20448              
============================================
- Hits          14231    14221      -10     
- Misses       123703   123720      +17     
+ Partials       1376     1371       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 7badb32 into MegaMek:master Jan 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Personnel Personnel-related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants