Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor grammar fixes #5749

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Minor grammar fixes #5749

wants to merge 2 commits into from

Conversation

repligator
Copy link
Collaborator

Mostly "are" to "is". See #5715.

@repligator repligator added the Personnel Personnel-related Issues label Jan 10, 2025
Copy link
Collaborator

@IllianiCBT IllianiCBT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't an appropriate fix, as the value of %s can be either the character's name, or the gender neutral 'they'

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.21%. Comparing base (fd739ba) to head (544acd0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5749      +/-   ##
============================================
- Coverage     10.21%   10.21%   -0.01%     
+ Complexity     6076     6073       -3     
============================================
  Files          1010     1010              
  Lines        139310   139310              
  Branches      20448    20448              
============================================
- Hits          14231    14224       -7     
- Misses       123703   123712       +9     
+ Partials       1376     1374       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@repligator
Copy link
Collaborator Author

Quick update: English is hard. For some reason words can become plural when the subject is singular and singular when the subject is plural. Sometimes they even become singular when the subject is singular and plural when the subject is plural.

Sue fidgets with their hair.
They fidget with their hair.

This is in addition to is/are.

Sue is smart.
They are smart.

You can sort of dodge the first issue by awkwardly rewording every sentence. For example, the following only needs the first two words in each sentence swapped to switch from given name to they.

Sue is often seen fidgeting with their hair.
They are often seen fidgeting with their hair.

However reading a paragraph where every sentence is written like this (tense? voice?) sounds incredibly unnatural. An ideal solution should be extensible, elegant, require as few resources as possible, and have natural sounding output. I haven't thought of anything that meets those criteria yet.

@IllianiCBT IllianiCBT marked this pull request as draft January 15, 2025 02:10
@IllianiCBT
Copy link
Collaborator

Converted this to 'draft' until a solution can be found, as we don't want it being merged by mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Personnel Personnel-related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants