Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove all the damage applier classes because they currently reside on megamek #5731

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

Scoppio
Copy link
Collaborator

@Scoppio Scoppio commented Jan 9, 2025

This code was moved to megamek.

@Scoppio Scoppio self-assigned this Jan 9, 2025
@Scoppio Scoppio requested a review from IllianiCBT January 9, 2025 20:44
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.21%. Comparing base (ceca9ba) to head (35ba081).
Report is 33 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5731      +/-   ##
============================================
+ Coverage     10.19%   10.21%   +0.01%     
+ Complexity     6074     6064      -10     
============================================
  Files          1011     1003       -8     
  Lines        139505   139215     -290     
  Branches      20504    20436      -68     
============================================
- Hits          14224    14215       -9     
+ Misses       123909   123623     -286     
- Partials       1372     1377       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@IllianiCBT IllianiCBT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me a while to go through all the code changes. But I can confirm these files have been deleted and no longer exist in mhq. :P

Jokes aside, LGTM

@Scoppio
Copy link
Collaborator Author

Scoppio commented Jan 14, 2025

Pls merge?

@Sleet01
Copy link
Collaborator

Sleet01 commented Jan 14, 2025

@Scoppio Will these checks be cleared up by the MM PRs currently awaiting merging?

> Task :MekHQ:compileJava
/home/runner/work/mekhq/mekhq/mekhq/MekHQ/src/mekhq/campaign/autoresolve/AtBSetupForces.java:22: error: cannot find symbol
import megamek.common.autoresolve.converter.ConsolidateForces;
                                           ^
  symbol:   class ConsolidateForces
  location: package megamek.common.autoresolve.converter
/home/runner/work/mekhq/mekhq/mekhq/MekHQ/src/mekhq/campaign/autoresolve/AtBSetupForces.java:47: error: AtBSetupForces is not abstract and does not override abstract method addOrdersToForces(SimulationContext) in SetupForces
public class AtBSetupForces extends SetupForces {
       ^
/home/runner/work/mekhq/mekhq/mekhq/MekHQ/src/mekhq/campaign/autoresolve/AtBSetupForces.java:67: error: cannot find symbol
        ConsolidateForces.consolidateForces(game, new SingleElementConsolidateForces());
        ^
  symbol:   variable ConsolidateForces
  location: class AtBSetupForces

@HammerGS HammerGS merged commit 92a314a into MegaMek:master Jan 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants