Fixed Maternity Leave... yet again #5725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved maternity leave status changes from Campaign to AbstractProcreation for better encapsulation and logic centralization. Ensured proper status updates when pregnancies end and added safeguards for returning personnel to active duty.
The code no longer redundantly resets maternity leave status for non-pregnant characters, as this logic was already handled elsewhere. Added unit tests to ensure correct behavior for various scenarios, such as different genders and pregnancy states. This cleanup improves clarity and prevents unnecessary status updates.
|
I think the tag should be "personal", because it is starting to get personal |
|
This is my own personnel hell, if you will |
Scoppio
approved these changes
Jan 9, 2025
|
If you disable procreation people will stop becoming pregnant, I don't believe it removes active pregnancies. |
NickAragua
approved these changes
Jan 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5725 +/- ##
============================================
- Coverage 10.21% 10.19% -0.02%
+ Complexity 6070 6067 -3
============================================
Files 1009 1010 +1
Lines 139242 139352 +110
Branches 20437 20447 +10
============================================
- Hits 14221 14212 -9
- Misses 123651 123765 +114
- Partials 1370 1375 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5714 (tentative)