Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Soft Cap to Support Point Generation #5708

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

IllianiCBT
Copy link
Collaborator

  • Added a soft cap to Support Points, where Administrators will not add new Support Points (during weekly generation) if Support Points already meet or exceed the number of required forces for the Contract. We received feedback that Support Points were a bit generous, under the current implementation, because the user could just stockpile them indefinitely.

Added checks to prevent exceeding maximum support points during support point negotiation. Introduced a user-facing message to inform when the limit is reached, ensuring clarity and proper feedback. Updated property file to include the new message text.
@IllianiCBT IllianiCBT added the StratCon Bugs relating strictly to StratCon label Jan 8, 2025
@IllianiCBT IllianiCBT self-assigned this Jan 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.03%. Comparing base (4cf3be1) to head (860882e).
Report is 92 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5708   +/-   ##
=========================================
  Coverage     10.02%   10.03%           
- Complexity     6068     6075    +7     
=========================================
  Files          1074     1074           
  Lines        141641   141652   +11     
  Branches      20645    20648    +3     
=========================================
+ Hits          14206    14213    +7     
- Misses       126063   126068    +5     
+ Partials       1372     1371    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sleet01 Sleet01 merged commit d85c65f into MegaMek:master Jan 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
StratCon Bugs relating strictly to StratCon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants