Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Scenario Reporting for Legacy AtB and StratCon Differentiation #5700

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

IllianiCBT
Copy link
Collaborator

  • Modified scenario reporting to distinguish between AtB and StratCon scenarios using context-specific messages.

Fix #5696

Modified scenario reporting to distinguish between AtB and StratCon scenarios using context-specific messages. Updated `Campaign.java` and localized strings in `Campaign.properties` to reflect these changes.
@IllianiCBT IllianiCBT added the GUI label Jan 8, 2025
@IllianiCBT IllianiCBT self-assigned this Jan 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.02%. Comparing base (4cf3be1) to head (fd61c12).
Report is 76 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5700      +/-   ##
============================================
- Coverage     10.02%   10.02%   -0.01%     
- Complexity     6068     6070       +2     
============================================
  Files          1074     1074              
  Lines        141641   141647       +6     
  Branches      20645    20647       +2     
============================================
  Hits          14206    14206              
- Misses       126063   126070       +7     
+ Partials       1372     1371       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sleet01 Sleet01 merged commit 57575af into MegaMek:master Jan 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE - 50.03 onwards] Reword or Remove 'Deploy from TO&E' Message for StratCon
3 participants