Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate required lances for manual AtB contracts for StratCon init #5232

Merged

Conversation

jslater89
Copy link

StratCon initialization requires a nonzero requiredLances to generate a nonzero number of tracks, and zero tracks causes a division by zero further along in initialization.

Solves issue #5181.

StratCon initialization requires a nonzero requiredLances to generate
a nonzero number of tracks, and zero tracks causes a division by zero
further along in initialization.
Copy link
Collaborator

@IllianiCBT IllianiCBT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we fixed this? Clearly not :D

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.51%. Comparing base (bce5f63) to head (65f2aa2).
Report is 48 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5232      +/-   ##
============================================
- Coverage     10.52%   10.51%   -0.01%     
+ Complexity     6047     6043       -4     
============================================
  Files           957      957              
  Lines        134523   134525       +2     
  Branches      19545    19545              
============================================
- Hits          14154    14150       -4     
- Misses       119018   119026       +8     
+ Partials       1351     1349       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@HammerGS HammerGS merged commit e396704 into MegaMek:master Nov 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants