Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored getCurrentPrisoners to use getActivePersonnel #5215

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Replaced getPersonnel with getActivePersonnel in getCurrentPrisoners method. This change ensures only active personnel are checked for prisoner status.

Closes #5182

Replaced `getPersonnel` with `getActivePersonnel` in `getCurrentPrisoners` method. This change ensures only active personnel are checked for prisoner status.
@IllianiCBT IllianiCBT added Bug Personnel Personnel-related Issues labels Nov 18, 2024
@IllianiCBT IllianiCBT self-assigned this Nov 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.50%. Comparing base (bce5f63) to head (cde4590).
Report is 22 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5215      +/-   ##
============================================
- Coverage     10.52%   10.50%   -0.02%     
+ Complexity     6047     6036      -11     
============================================
  Files           957      957              
  Lines        134523   134523              
  Branches      19545    19545              
============================================
- Hits          14154    14134      -20     
- Misses       119018   119035      +17     
- Partials       1351     1354       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@HammerGS HammerGS merged commit a89a4f0 into MegaMek:master Nov 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Personnel Personnel-related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dead prisoners triggering POW nag
3 participants