Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Unit Site Comparison Logic #5214

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Replaced SITE_FACILITY_MAINTENANCE with SITE_FACILITY_BASIC in the comparison logic for unit site determination. This ensures planetary modifiers are only applied in appropriate circumstances.

Closes #5184

Replaced `SITE_FACILITY_MAINTENANCE` with `SITE_FACILITY_BASIC` in the comparison logic for unit site determination. This ensures planetary modifiers are only applied in appropriate circumstances.
@IllianiCBT IllianiCBT added the Bug label Nov 18, 2024
@IllianiCBT IllianiCBT self-assigned this Nov 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.50%. Comparing base (bce5f63) to head (aee5977).
Report is 20 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5214      +/-   ##
============================================
- Coverage     10.52%   10.50%   -0.02%     
+ Complexity     6047     6029      -18     
============================================
  Files           957      957              
  Lines        134523   134523              
  Branches      19545    19545              
============================================
- Hits          14154    14128      -26     
- Misses       119018   119035      +17     
- Partials       1351     1360       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@HammerGS HammerGS merged commit 7dd4097 into MegaMek:master Nov 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extreme weather maintenance debuffs are being applied to units in a Facility - Basic location
3 participants