Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rank Systems to Version 0.50.2-SNAPSHOT #5210

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Incremented the rank systems version in ranks.xml from 0.50.1-SNAPSHOT to 0.50.2-SNAPSHOT. This stops IDEA from pestering us to update it any time we make a change in mhq.

Incremented the rank systems version in ranks.xml from 0.50.1-SNAPSHOT to 0.50.2-SNAPSHOT. This stops IDEA from pestering us to update it any time we make a change in mhq.
@IllianiCBT IllianiCBT self-assigned this Nov 18, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.52%. Comparing base (907de4f) to head (99f9bb2).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5210   +/-   ##
=========================================
  Coverage     10.52%   10.52%           
  Complexity     6044     6044           
=========================================
  Files           957      957           
  Lines        134523   134523           
  Branches      19545    19545           
=========================================
  Hits          14153    14153           
+ Misses       119021   119015    -6     
- Partials       1349     1355    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@@ -1,3 +1,3 @@
<?xml version="1.0" encoding="UTF-8"?>
<rankSystems version="0.50.1-SNAPSHOT">
<rankSystems version="0.50.2-SNAPSHOT">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 50.02

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, yes, but not according to our versioning. I think Tex might need to take a look at that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just fixed it :)
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! I'll get this PR updated when I'm home :)

Updated the rankSystems version from "0.50.2-SNAPSHOT" to "0.50.02-SNAPSHOT". This ensures consistency in version naming across the project.
@IllianiCBT IllianiCBT merged commit 3abd872 into MegaMek:master Nov 24, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants