Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Contract Automation #5172

Merged
merged 7 commits into from
Nov 7, 2024
Prev Previous commit
Next Next commit
Remove obsolete comments in CampaignXmlParser
The outdated comments regarding SpecialAbility and error handling in processAutomatedMothballNodes were removed. This cleanup improves code readability and maintains the focus on current logic.
IllianiCBT committed Nov 5, 2024
commit 9f4df35174ab22b6a694fedfcaffc77f2468d021
3 changes: 0 additions & 3 deletions MekHQ/src/mekhq/campaign/io/CampaignXmlParser.java
Original file line number Diff line number Diff line change
@@ -942,7 +942,6 @@ private static void processFameAndInfamyNodes(Campaign relativeValue, Node worki
private static List<Unit> processAutomatedMothballNodes(Node workingNode, Campaign campaign) {
logger.info("Loading Automated Mothball Nodes from XML...");

// TODO: make SpecialAbility a Campaign instance
List<Unit> mothballedUnits = new ArrayList<>();

NodeList workingList = workingNode.getChildNodes();
@@ -955,8 +954,6 @@ private static List<Unit> processAutomatedMothballNodes(Node workingNode, Campai
}

if (!childNode.getNodeName().equalsIgnoreCase("mothballedUnit")) {
// Error condition of sorts!
// Errr, what should we do here?
logger.error("Unknown node type not loaded in Automated Mothball nodes: "
+ childNode.getNodeName());
continue;