Added New StratCon Scenario Generation Utility Method #5142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted repeated logic into helper methods and consolidated map location imports. Enhanced clarity and maintainability by introducing generateExternalScenario and finalizeBackingScenario methods.
Extracted repeated logic into helper methods and consolidated map location imports. Enhanced clarity and maintainability by introducing generateExternalScenario and finalizeBackingScenario methods.
Replaced tracks.size() > 0 with tracks.isEmpty() to improve readability. Added a return statement to abort scenario generation if no tracks are available, preventing potential errors.
IllianiCBT
added
StratCon
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5142 +/- ##
=========================================
Coverage 10.53% 10.53%
Complexity 6041 6041
=========================================
Files 956 956
Lines 134253 134305 +52
Branches 19501 19513 +12
=========================================
+ Hits 14142 14148 +6
- Misses 118760 118806 +46
Partials 1351 1351 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Oct 29, 2024
|
This has picked up conflicts |
# Conflicts: # MekHQ/src/mekhq/campaign/stratcon/StratconContractInitializer.java
Integrated the MekSearchFilter import to support advanced unit searching capabilities. This update is part of an enhancement for improved search functionality within the MekHQ unit selection dialog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new helper method to
StratconRulesManagerthat allows Classes outside of StratCon to spawn StratCon scenarios. These scenarios can be spawned either on a random or specific Track. Likewise, the scenario template can be either specific or random.I also extracted some repeated logic into helper methods and consolidated map location imports, seeing that they're being used in a whole bunch of places in this class.
Finally, I adjusted
generateScenariosForTrack(which my new method is based on) to only place scenarios in unoccupied locations. This should help avoid scenarios being lost under facilities (or visa versa) and is meant to work alongside the changes made in #5141.