Refactored Field Kitchen Personnel Count Logic #5140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Field Kitchens will no longer count Prisoners against their limit, unless the Prisoner has a role. Furthermore, support personnel are no longer counted in the campaign summary screen (this was a visual bug only).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5140 +/- ##
=========================================
Coverage 10.53% 10.53%
- Complexity 6041 6045 +4
=========================================
Files 956 956
Lines 134253 134275 +22
Branches 19501 19507 +6
=========================================
+ Hits 14142 14149 +7
- Misses 118760 118773 +13
- Partials 1351 1353 +2 ☔ View full report in Codecov by Sentry. |
Updated the logic for filtering personnel to correctly identify those who should be included based on their prisoner status and role. This change ensures that personnel count calculations are accurate when using the field kitchen feature.
HammerGS
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Field Kitchens will no longer count Prisoners against their limit, unless the Prisoner has a role. Furthermore, support personnel are no longer counted in the campaign summary screen (this was a visual bug only).
Closes #5139