Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Campaign Options IIC Preset Picker #4981

Merged

Conversation

IllianiCBT
Copy link
Collaborator

Replaced the existing preset picker class with SelectPresetDialog - the preset picker that was developed for the Campaign Options IIC project.

I figured compartmentalizing would make reviewing easier. Especially as CO IIC is going to be a hefty merge.

image
image

Confirm is a new dialog option added, this completely bypasses the campaign options dialog (users can still pick their date, of course). Once CO IIC is out, we'll have the contents of the General Tab pop up after the date chooser, but for now it will just apply the relevant campaign options and be done.

Replaced the existing preset picker class with `SelectPresetDialog` - the preset picker that was developed for the Campaign Options IIC project.

I figured compartmentalizing would make reviewing easier. Especially as CO IIC is going to be a hefty merge.
@IllianiCBT IllianiCBT added GUI Refactoring UX User experience Campaign Options Relates to, or includes, campaign option changes labels Oct 4, 2024
@IllianiCBT IllianiCBT self-assigned this Oct 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.47%. Comparing base (415ecaf) to head (1d299da).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##             master    #4981    +/-   ##
==========================================
  Coverage     10.47%   10.47%            
- Complexity     6021     6031    +10     
==========================================
  Files           951      950     -1     
  Lines        133248   133367   +119     
  Branches      19377    19382     +5     
==========================================
+ Hits          13961    13975    +14     
- Misses       117940   118045   +105     
  Partials       1347     1347            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT
Copy link
Collaborator Author

I forgot to leave a note about the naming of the resource bundle. This is a temporary name in-use while CO IIC is in-dev. It’ll be given a more appropriate name once we no longer have elements from both current CO and IIC

Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work.

@HammerGS HammerGS merged commit 393f85a into MegaMek:master Oct 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Campaign Options Relates to, or includes, campaign option changes GUI Refactoring UX User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants