Added Era Buttons to Date Chooser and Modernized GUI #4945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the DateChooser class to support internationalization using ResourceBundle for dynamic text handling. Introduced new era selection buttons for different eras in the UI.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4945 +/- ##
==========================================
Coverage 10.44% 10.44%
- Complexity 5998 6007 +9
==========================================
Files 951 951
Lines 132874 132976 +102
Branches 19329 19330 +1
==========================================
+ Hits 13873 13886 +13
- Misses 117653 117738 +85
- Partials 1348 1352 +4 ☔ View full report in Codecov by Sentry. |
Eliminated the obsolete era-related constants from DateChooser to clean up the codebase. Updated the button action listener to use the setDate method and dispose of the dialog afterward.
Renamed methods and variables for better readability. Added a "Confirm Date" button to the DateChooser dialog and restructured dialogue layout for improved user interaction.
Ensured the DateChooser dialog only closes if the date is valid by modifying `updateDateFromDateField` to return a boolean. Removed unnecessary logic in focusLost and keyReleased methods to simplify code and prevent erroneous updates.
Ensured the DateChooser dialog only closes if the date is valid by modifying `updateDateFromDateField` to return a boolean. Removed unnecessary logic in focusLost and keyReleased methods to simplify code and prevent erroneous updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the DateChooser class to support internationalization using ResourceBundle for dynamic text handling. Introduced new era selection buttons for different eras in the UI.
Closes #4662