Refactored GM Person Editing to Handle Multiple Selections #4884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added color-coded messaging to ensure random death events are highly noticeable to users. Imported necessary utilities and refined new day processing to utilize the enhanced reporting mechanism.
Revised the `PersonnelTableMouseAdapter` to iterate through all selected people rather than processing a single person. Updated the `edit.text` resource to `editPerson.text` for improved clarity and consistency.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4884 +/- ##
============================================
- Coverage 10.31% 10.29% -0.02%
+ Complexity 5872 5862 -10
============================================
Files 944 944
Lines 131403 131404 +1
Branches 19064 19065 +1
============================================
- Hits 13548 13529 -19
- Misses 116539 116550 +11
- Partials 1316 1325 +9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised the
PersonnelTableMouseAdapterto iterate through all selected people rather than processing a single person. Updated theedit.textresource toeditPerson.textfor improved clarity and consistency.Partially Closes #4752