Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out inactive factions when determining capitals for personnel market generation #4882

Merged

Conversation

Algebro7
Copy link
Collaborator

PersonnelMarket.java was not filtering out inactive factions when determining whether a planetary system was a faction capital. This led to situations where personnel would be generated on a planet like Styk before Styk actually became a faction capital in 3058. This PR adds a filter when populating the local variable factions and also changes the c argument to for this method to campaign.

Closes #4871

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.31%. Comparing base (2ef3222) to head (e7b088d).
Report is 13 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4882      +/-   ##
============================================
- Coverage     10.31%   10.31%   -0.01%     
- Complexity     5872     5874       +2     
============================================
  Files           944      944              
  Lines        131403   131404       +1     
  Branches      19064    19064              
============================================
  Hits          13548    13548              
- Misses       116539   116544       +5     
+ Partials       1316     1312       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 0abb733 into MegaMek:master Sep 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting Personnel Reports while away from Hiring Hall/Capital
4 participants