Filter out inactive factions when determining capitals for personnel market generation #4882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PersonnelMarket.java was not filtering out inactive factions when determining whether a planetary system was a faction capital. This led to situations where personnel would be generated on a planet like Styk before Styk actually became a faction capital in 3058. This PR adds a filter when populating the local variable
factions
and also changes thec
argument to for this method tocampaign
.Closes #4871