Updated StratCon Status Message for Inactive Contracts #4880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added color-coded messaging to ensure random death events are highly noticeable to users. Imported necessary utilities and refined new day processing to utilize the enhanced reporting mechanism.
Extended the message to clarify when no active contract is selected or the contract has not yet started. This provides better feedback to users regarding the state of their campaign.
Extended the message to clarify when no active contract is selected or the contract has not yet started. This provides better feedback to users regarding the state of their campaign.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4880 +/- ##
============================================
- Coverage 10.31% 10.30% -0.01%
+ Complexity 5872 5866 -6
============================================
Files 944 944
Lines 131403 131402 -1
Branches 19064 19064
============================================
- Hits 13548 13535 -13
- Misses 116539 116548 +9
- Partials 1316 1319 +3 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the message to clarify when no active contract is selected or the contract has not yet started. This provides better feedback to users regarding the state of their campaign.
###Closes #4701