-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Mission.properties #4751
Conversation
Fixed Typo
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4751 +/- ##
============================================
+ Coverage 10.31% 10.32% +0.01%
- Complexity 5881 5889 +8
============================================
Files 944 944
Lines 131420 131420
Branches 19061 19061
============================================
+ Hits 13552 13567 +15
+ Misses 116535 116522 -13
+ Partials 1333 1331 -2 ☔ View full report in Codecov by Sentry. |
Sorry the tests took so long to run, GitHub makes us run them manually when a first time contributor pushes a PR. Welcome to the project! :) |
It looks like one of the tests failed, this is likely due to you needing to update the branch on all three repos: mm, mml, and mhq. If you're unsure how let us know and we can likely guide you through it |
Point of note... use branches instead of your master. |
In fact, I'm going to recommend you kill your fork, re-fork, and do the spelling fix in a branch so that any future changes can be done without issues with this main repo if you decide to do anything with your master branch. |
I'm going to go ahead and merge this, but I'm going to echo Tex above and highly recommend you avoid working in your master branch moving forward. You really should be using working branches whenever you make edits, even if they're simple ones like this. When things go wrong, Future You will greatly appreciate the extra couple of steps needed to open a working branch. If you're unsure how, pop a question in the coding help channel of our discord and one of us would be happy to guide you through it :) |
Fixed Typo