Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for Hiring Hall levels and add new hiring halls #4659

Closed
wants to merge 2 commits into from

Conversation

Algebro7
Copy link
Collaborator

This refactors some internals in AtBConfiguration to provide support for different levels of hiring halls, which is necessary to implement support for CamOps. The "public" API hasn't changed except for a new getHiringHallLevel() method, and old save files are of course supported. This information will also be useful for displaying the hiring hall level in the UI, such as on the planetary map.

This also adds a handful of hiring halls that previously weren't in the game based on CamOps and Sarna. I added an approximation of the level based on Sarna in cases where an explicit official hiring hall level wasn't given.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.79%. Comparing base (cef4c6c) to head (fa58da2).
Report is 104 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4659      +/-   ##
============================================
+ Coverage      9.90%   10.79%   +0.89%     
- Complexity     5676     5712      +36     
============================================
  Files           945      952       +7     
  Lines        129636   131308    +1672     
  Branches      19092    19138      +46     
============================================
+ Hits          12836    14181    +1345     
- Misses       115583   115904     +321     
- Partials       1217     1223       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Algebro7
Copy link
Collaborator Author

I've cherry picked these commits into my larger camops contract market branch, and given that they aren't needed for other features ATM I'm thinking it makes sense to close this and just merge these changes with PR #4644 . Closing for now but let me know if we want to re-open later for some reason.

@Algebro7 Algebro7 closed this Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants