-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin work on implementing CamOps Contract Market #4644
Merged
IllianiCBT
merged 49 commits into
MegaMek:master
from
Algebro7:refactor-contract-market
Sep 25, 2024
Merged
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
f759068
WIP: initial work on refactoring contract markets to support other types
Algebro7 0acd2a1
use AtBContract for contractmarket interface
Algebro7 c5bb252
WIP: refactor to abstract contract market
Algebro7 adf5f3d
WIP: move over to abstractcontractmarket
Algebro7 ef3f8b2
remove unnecessary constructor and stub out abstract methods in camop…
Algebro7 8ec9cb2
stub out abstract methods
Algebro7 1bf626d
enable contract market setting
Algebro7 c596454
move to specific package
Algebro7 0ee9326
remove debug code
Algebro7 b75dd4f
add loading/saving from campaign files
Algebro7 5b9355d
add method to find best personnel with skill regardless of role and n…
Algebro7 ca49c1c
use abstractcontractmarket instead of contractmarket
Algebro7 6298607
WIP: implement camopscontractmarket
Algebro7 f032897
refactor hiring halls to support different levels; add new hiring halls
Algebro7 46f49b2
remove debugging code
Algebro7 3890ff3
WIP: adding more contract generation functionality
Algebro7 857e186
various fixes for merge conflicts
Algebro7 133b69d
remove unnecessary imports
Algebro7 de542b6
switch to correct MMLogger
Algebro7 f9f5b50
remove unneeded import
Algebro7 ad13ed3
move camops contract data XML
Algebro7 8748cba
WIP: camops contract data
Algebro7 27f8e93
remove XML camops contract data
Algebro7 545cbb9
add camops independent employer tags
Algebro7 7ae4cda
update allowed tags
Algebro7 33cb37f
add method for retrieving active factions
Algebro7 0e4a459
finish determine employer and begin work on determining mission type
Algebro7 4ca5d4e
add warning to camops contract market option
Algebro7 f5a514f
add word wrap
Algebro7 ea33475
extract getMissionType to abstract class
Algebro7 4b2227e
extract contract enemy code generation to abstract class
Algebro7 7c4a49b
extract riot duty adjustment
Algebro7 dacd82e
extract more methods; add isAttacker to the contract
Algebro7 6f2a615
fix whitespace
Algebro7 1cf7ee8
use class-specific logger in child classes
Algebro7 7691708
move abstract method to private; finish contract generation routine f…
Algebro7 76fc8a6
extract updateReport()
Algebro7 1b0260b
clear out old contracts at beginning of month
Algebro7 f73cc52
remove erroneous import
Algebro7 acd498a
move calculatePaymentMultiplier() to AbstractContractMarket
Algebro7 6ee08ac
add method to retrieve strategy skill of the commander
Algebro7 d478f7c
extract more methods from AtBContract to AbstractContractMarket
Algebro7 60650ed
fix error in employer name in contract
Algebro7 32373a8
remember to set required lances on contract
Algebro7 e20c7ad
add javadocs
Algebro7 8e02e7e
add more javadocs
Algebro7 19a8656
remove unneeded variables
Algebro7 a79000f
add TODOs
Algebro7 dcf55ed
implement addAtBContract
Algebro7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a heads up, we're moving towards having everything JavaDoc'd, obviously not necessary while this is a WIP but something you'll likely need to address before it gets merged. We're aware the majority of our stuff isn't currently JavaDoc'd, so that's something we're trying to address. So if you create a new Class, Method, or edit an existing Class or Method please add JavaDoc's*
*This is going to be added to the automated tests at some point