Fixed & Optimized Total Profits Calculation & Removed Exemptions #4306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Optimized getProfits method with stream operations - Removed faction exemptions from payTaxes method
NickAragua
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses and optimizes a calculation error in the profits method. Previously, profits were incorrectly failing to discount
Starting CapitalandFinancial Term End Carry Over, resulting in higher-than-intended taxes and Shares payouts. While fixing this, I also optimized the calculation to better handle large volumes of financial transactions.Additionally, following a conversation with Nick about Campaign Options (see #4281), I removed the two tax exemption campaign options. The reasoning is that users who want their campaign to be exempt from taxes can simply choose not to enable taxes.