Fixed Original Unit Value Being Deducted from Payout Sum When Personnel Resign/Retire #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unnecessary if conditions and repetition - Used unit sell value instead of buy cost for payout calculation
HammerGS
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an unintended interaction where personnel would reduce their payout value based on the value of the unit they are given, when resigning or retiring, even if that unit was a unit they owned.
Furthermore, I adjusted the value of mechs being given as part-payment so that they use the sell value of the unit and not the buy price. This ensures mhq isn't treating half an atlas as equal to an intact atlas.