Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Dialog Option for Invalid Faction Nag #4273

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

IllianiCBT
Copy link
Collaborator

The new invalid faction nag was incorrectly enabled or disabled by the cargo capacity nag. This PR switches it to correctly use the invalid faction nag option, instead.

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 10.28%. Comparing base (6b123d7) to head (ce980e4).
Report is 6 commits behind head on master.

Files Patch % Lines
MekHQ/src/mekhq/gui/dialog/MHQOptionsDialog.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4273   +/-   ##
=========================================
  Coverage     10.28%   10.28%           
  Complexity     5816     5816           
=========================================
  Files           925      925           
  Lines        125892   125892           
  Branches      18636    18636           
=========================================
  Hits          12954    12954           
  Misses       111666   111666           
  Partials       1272     1272           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT merged commit f76d2f2 into MegaMek:master Jun 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants