Updated Child Education Level Handling & Academy Name Generation #4229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nelDialog and Campaign classes
- Added new school types to Education.properties - Added 'generateTypeChild' method to generate random educational institution type in EducationController.java - Updated 'generateName' method to handle PrepSchool type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates academy name generation to use a curated list for prep schools. Previously, it was using the adult name generation list, resulting in 3-year-olds "attending" university. Although this was only a visual bug, it was an easy fix so it made sense to address it before launch.
Additionally, I added a couple of clauses to Bulk Personnel recruitment and the birth process to better handle the education level for people generated by those systems. Previously, individuals were being born having already graduated from high school, which was not intended.