Fix null date check in OutstandingScenariosNagLogic

Moved the null date check earlier in the loop to avoid potential null pointer exceptions when processing scenarios. This ensures scenarios with null dates are skipped before any operations on their dates are conducted.
MegaMek · Jan 13, 2025 · d55f348 · d55f348
1 parent bc20a6d
commit d55f348
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/MekHQ/src/mekhq/gui/dialog/nagDialogs/nagLogic/OutstandingScenariosNagLogic.java b/MekHQ/src/mekhq/gui/dialog/nagDialogs/nagLogic/OutstandingScenariosNagLogic.java
@@ -53,12 +53,12 @@ public static String getOutstandingScenarios(Campaign campaign) {
             for (AtBScenario scenario : contract.getCurrentAtBScenarios()) {
                 LocalDate scenarioDate = scenario.getDate();
 
-                // Skip scenarios not matching today's date
-                if (!scenarioDate.equals(today)) {
+                if (scenario.getDate() == null) {
                     continue;
                 }
 
-                if (scenario.getDate() == null) {
+                // Skip scenarios not matching today's date
+                if (!scenarioDate.equals(today)) {
                     continue;
                 }