Improve performance by breaking loops on role check failure

Added `break` statements to terminate loops early when a selected person cannot perform the specified role. This prevents unnecessary checks and enhances efficiency in role validation.
MegaMek · Jan 10, 2025 · 1545cb6 · 1545cb6
1 parent 7553aa4
commit 1545cb6
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/MekHQ/src/mekhq/gui/adapter/PersonnelTableMouseAdapter.java b/MekHQ/src/mekhq/gui/adapter/PersonnelTableMouseAdapter.java
@@ -1497,6 +1497,7 @@ protected Optional<JPopupMenu> createPopupMenu() {
             for (Person selectedPerson : getSelectedPeople()) {
                 if (!selectedPerson.canPerformRole(gui.getCampaign().getLocalDate(), role, true)) {
                     allCanPerform = false;
+                    break;
                 }
             }
 
@@ -1519,6 +1520,7 @@ protected Optional<JPopupMenu> createPopupMenu() {
             for (Person selectedPerson : getSelectedPeople()) {
                 if (!selectedPerson.canPerformRole(gui.getCampaign().getLocalDate(), role, false)) {
                     allCanPerform = false;
+                    break;
                 }
             }