Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabbed UI Polish Pass #1697

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Tabbed UI Polish Pass #1697

merged 5 commits into from
Jan 24, 2025

Conversation

pavelbraginskiy
Copy link
Member

Lots of small fixes and QOL improvements:

  • Ensure that renaming a unit renames its tab, even after switching unit type.
  • Only show the "Are you sure" prompt for operations where it makes sense, i.e. not loading a unit in a new tab.
  • Fix "Load from file" not working from the startup GUI.
  • Allow you to close tabs by middle-clicking them.

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.13%. Comparing base (a493832) to head (9205ab7).
Report is 12 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #1697      +/-   ##
===========================================
- Coverage      2.13%   2.13%   -0.01%     
  Complexity      209     209              
===========================================
  Files           271     271              
  Lines         31380   31409      +29     
  Branches       5341    5342       +1     
===========================================
  Hits            670     670              
- Misses        30553   30582      +29     
  Partials        157     157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sleet01 Sleet01 merged commit ce42bfb into MegaMek:master Jan 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants