Fix font rendering of symbols on windows using gradle run
#1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1688 +/- ##
========================================
Coverage 2.13% 2.13%
Complexity 209 209
========================================
Files 272 272
Lines 31441 31437 -4
Branches 5352 5351 -1
========================================
Hits 670 670
+ Misses 30614 30610 -4
Partials 157 157 ☔ View full report in Codecov by Sentry. |
Sleet01
approved these changes
Jan 9, 2025
|
@pavelbraginskiy looks like there's a conflict since merging the updated-tab PR. |
# Conflicts: # megameklab/src/megameklab/ui/MegaMekLabTabbedUI.java
pavelbraginskiy
force-pushed
the
font-fix
branch
from
09e0936 to
bd13ec2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just hoping the system has Symbola or a suitable fallback font available, this forces the use of Noto Sans Symbols 2, a font we already include with MegaMek.
This fixes the issue that some icons wouldn't render properly when using
gradle runon Windows.