Tabbed UI Improvements #1679
Merged
Tabbed UI Improvements #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1679 +/- ##
===========================================
- Coverage 2.14% 2.13% -0.01%
Complexity 209 209
===========================================
Files 270 270
Lines 31247 31350 +103
Branches 5328 5337 +9
===========================================
Hits 670 670
- Misses 30420 30523 +103
Partials 157 157 ☔ View full report in Codecov by Sentry. |
pavelbraginskiy
force-pushed
the
tabbed-ui
branch
from
8a84d55 to
1df5dc1
Compare
| var line = sc.nextLine().split(Pattern.quote(MtfFile.SIZE)); | ||
| var type = EquipmentType.get(line[0]); | ||
| var mounted = Mounted.createMounted(loadedUnit, type); | ||
| if (line.length > 1) { |
Check warning
Code scanning / CodeQL
Expression always evaluates to the same value Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvement to the new Tabs UI.
First, when tabs are restored, equipment not allocated to a location is no longer lost, making that feature more reliable.
Second, new ways to open a new tab:
The old + button can now be right-clicked to select a unit type:
The new ⌸ button will load a unit from cache, and can be right clicked to load a unit from a file:
