Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHQ RFE 5604: save refit files from MHQ MekLab tab (MML side) #1678

Merged
merged 3 commits into from
Jan 5, 2025

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Jan 4, 2025

Supporting code changes to allow MHQ to utilize the existing unit saving code within its MekLab tab.
Changes include:

  • Moving much of the MTF / BLK file saving code from the MML menu bar UI code out to a separate class;
  • Creating a new interface based on the existing save functionality to facilitate using this new class with MHQ;
  • Separating the entity-related code from the file-save-related code as much as possible.

Testing:

  • Ran all 3 projects' unit tests
  • Loaded and saved multiple units of various kinds with the updated code.

NOTE: this PR only sets up the code needed by the MHQ PR, which will close the above RFE issue.
The other PR is here.

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.14%. Comparing base (a2abcdd) to head (d74b4e9).
Report is 13 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #1678      +/-   ##
===========================================
- Coverage      2.14%   2.14%   -0.01%     
  Complexity      209     209              
===========================================
  Files           270     271       +1     
  Lines         31247   31261      +14     
  Branches       5328    5330       +2     
===========================================
  Hits            670     670              
- Misses        30420   30434      +14     
  Partials        157     157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sleet01 Sleet01 marked this pull request as draft January 4, 2025 00:43
@Sleet01
Copy link
Collaborator Author

Sleet01 commented Jan 4, 2025

Just realized that the new files need headers; converting to draft for now.

@Sleet01 Sleet01 marked this pull request as ready for review January 4, 2025 01:14
Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-Pilot checked and not issues found.

@HammerGS HammerGS merged commit 1373184 into MegaMek:master Jan 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants