Allow opening multiple units in tabs #1673
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1673 +/- ##
===========================================
- Coverage 2.16% 2.14% -0.02%
Complexity 209 209
===========================================
Files 268 270 +2
Lines 30930 31247 +317
Branches 5289 5328 +39
===========================================
+ Hits 669 670 +1
- Misses 30104 30420 +316
Partials 157 157 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@pavelbraginskiy Can you grab the Edit: NM, that's just the record sheet font. Where is MML setting its default display font... |
| CConfig.getMainUiWindowSize(this).ifPresent(this::setSize); | ||
| CConfig.getMainUiWindowPosition(this).ifPresent(this::setLocation); | ||
|
|
||
| // ...and save that size nad position on exit |
| return true; | ||
| } | ||
|
|
||
| private void restrictToScrenSize() { |
| //<editor-fold desc="MenuBarOwner interface implementation"> | ||
| @Override | ||
| public JFrame getFrame() { | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public Entity getEntity() { | ||
| return currentEditor().getEntity(); | ||
| } | ||
|
|
||
| @Override | ||
| public String getFileName() { | ||
| return currentEditor().getFileName(); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean hasEntityNameChanged() { | ||
| return currentEditor().hasEntityNameChanged(); | ||
| } | ||
|
|
||
| @Override | ||
| public void refreshMenuBar() { | ||
| menuBar.refreshMenuBar(); | ||
| } | ||
|
|
||
| @Override | ||
| public MenuBar getMMLMenuBar() { | ||
| return menuBar; | ||
| } | ||
| //</editor-fold> |
There was a problem hiding this comment.
I don't think IDE-specific formatting comments should be included in the main repo.
| ) { | ||
| ps.println(((Mek) editor.getEntity()).getMtf()); | ||
| } catch (Exception e) { | ||
| continue; |
There was a problem hiding this comment.
This definitely needs logging of the exception; no silent file errors.
| try { | ||
| BLKFile.encode(unitFile.getPath(), editor.getEntity()); | ||
| } catch (EntitySavingException e) { | ||
| continue; |
| editor.reloadTabs(); | ||
| editor.refreshAll(); | ||
| editors.add(editor); | ||
| } catch (EntityLoadingException ignored) {} |
There was a problem hiding this comment.
We definitely want logging of exceptions while attempting to read unit files.
|
|
||
| try { | ||
| Entity loadedUnit = new MekFileParser(newFile).getEntity(); | ||
| newFile.delete(); |
There was a problem hiding this comment.
I'd argue that we shouldn't delete any files until we've completed all actions in the try block.
There was a problem hiding this comment.
In addition to the stuff I commented on, I think we need to add the standard tab-related menu items and symantics:
- File -> Close, to mirror the X button function;
- File -> Open, similar to load but replaces the current tab's contents with the selected unit.
- Wrap the selected tab around instead of creating infinite new tabs, when using CTRL+Tab and right arrow in the tab bar.
Otherwise, this looks fantastic and I'm hyped to start using the tabs!
Many people have requested the ability to have many units open at once.
Everything seems to just work the way you might expect it to, but I'd like to get this to the testers to try to break it as soon as possible.
This shouldn't impact MekHQ, and when I opened MHQ MML it didn't instantly explode, but I don't know how to use MHQ so testing is necessary to make sure everything really does still work there.
You can shift-click the close-tab button to skip the "Would you like to save" dialog.
When you close MML, the state of the tabs is saved to a hidden directory in the user folder.
If the startup mode is set to "Restore Tabs", a user can pick up right where they left off, even including any unsaved work.
Future work: