Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatusBar: correct free slot displays #1355

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Dec 29, 2023

The statusbars were showing the used slots instead of free slots when the label said "Free Slots:". Also change a button label to reduce its width.

@HammerGS
Copy link
Member

Tested and seems to work just fine to me.

Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work fine to me.

err....maybe not...or I'm just missing something.

image

Says it's got 40 free slots, but adding them up is 38

@SJuliez
Copy link
Member Author

SJuliez commented Dec 29, 2023

How did you arrive there? Are you sure you were using this branch? When you add equipment, do the free slots go up - because that was the former behavior...

image

@SJuliez
Copy link
Member Author

SJuliez commented Dec 29, 2023

Btw the top button bar is also not supposed to have this white background. If that is always the case, it's also an issue

@HammerGS
Copy link
Member

Just tried it again, and it's working. When I was bouncing between branches Eclipses must not have liked it. But all working.

@HammerGS HammerGS merged commit a7394a4 into MegaMek:master Dec 29, 2023
3 of 4 checks passed
HammerGS added a commit that referenced this pull request Dec 29, 2023
@SJuliez SJuliez deleted the statusbar-correction branch March 9, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants