Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weapon attack cleanup #5922

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
+232 −306

refactor: Use stream composition for C3 with active probes

014cb8f
Select commit
Loading
Failed to load commit list.
Open

Weapon attack cleanup #5922

refactor: Use stream composition for C3 with active probes
014cb8f
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL completed Aug 24, 2024 in 5s

1 configuration not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 1 configuration present on refs/heads/master was not found:

Actions workflow (codeql-analysis.yml)

  • ❓  .github/workflows/codeql-analysis.yml:analyze/java-distribution:temurin/java-version:/language:java/os:ubuntu-latest

New alerts in code changed by this pull request

  • 1 warning

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 976 in megamek/src/megamek/common/actions/WeaponAttackAction.java

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
weapon
Loading
may be null at this access as suggested by
this
Loading
null guard.
Variable
weapon
Loading
may be null at this access as suggested by
this
Loading
null guard.
Variable
weapon
Loading
may be null at this access as suggested by
this
Loading
null guard.
Variable
weapon
Loading
may be null at this access as suggested by
this
Loading
null guard.
Variable
weapon
Loading
may be null at this access as suggested by
this
Loading
null guard.
Variable
weapon
Loading
may be null at this access as suggested by
this
Loading
null guard.
Variable
weapon
Loading
may be null at this access as suggested by
this
Loading
null guard.
Variable
weapon
Loading
may be null at this access as suggested by
this
Loading
null guard.
Variable
weapon
Loading
may be null at this access as suggested by
this
Loading
null guard.
Variable
weapon
Loading
may be null at this access as suggested by
this
Loading
null guard.
Variable
weapon
Loading
may be null at this access as suggested by
this
Loading
null guard.
Variable
weapon
Loading
may be null at this access as suggested by
this
Loading
null guard.
Variable
weapon
Loading
may be null at this access as suggested by this null guard.